issue-698, Save default user ref for cassandra #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksiienkoMykyta
force-pushed
the
issue-698-Save-default-user-ref-for-cassandra
branch
3 times, most recently
from
c64ae6c
to
e758e98
Compare
tengu-alt
approved these changes
Feb 21, 2024
ribaraka
requested changes
Feb 21, 2024
Comment on lines
618
to
637
| func (c *Cassandra) NewDefaultUserSecret(username, password string) *k8scorev1.Secret { | ||
| return &k8scorev1.Secret{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| Kind: models.SecretKind, | ||
| APIVersion: models.K8sAPIVersionV1, | ||
| }, | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: fmt.Sprintf(models.DefaultUserSecretNameTemplate, models.DefaultUserSecretPrefix, c.Name), | ||
| Namespace: c.Namespace, | ||
| Labels: map[string]string{ | ||
| models.ControlledByLabel: c.Name, | ||
| models.DefaultSecretLabel: "true", | ||
| }, | ||
| }, | ||
| StringData: map[string]string{ | ||
| models.Username: username, | ||
| models.Password: password, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
please make this func generic
Comment on lines
334
to
336
| l.Info("Cassandra cluster has been created", | ||
| "cluster ID", c.Status.ID, | ||
| ) |
There was a problem hiding this comment.
no need for this log. it's already been logged
| @@ -895,6 +914,59 @@ func (r *CassandraReconciler) newWatchBackupsJob(c *v1beta1.Cassandra) scheduler | |||
| } | |||
| } | |||
|
|
|||
| func (r *CassandraReconciler) createDefaultSecret(ctx context.Context, c *v1beta1.Cassandra, l logr.Logger) error { | |||
There was a problem hiding this comment.
please try to make it generic as well
OleksiienkoMykyta
force-pushed
the
issue-698-Save-default-user-ref-for-cassandra
branch
2 times, most recently
from
ddc79cc
to
0785828
Compare
OleksiienkoMykyta
force-pushed
the
issue-698-Save-default-user-ref-for-cassandra
branch
from
0785828
to
39c70f8
Compare
ribaraka
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.